[API Implementation]: SafeFileHandle overloads for SetCreationTime, SetLastAccessTime, SetLastWriteTime #60507

deeprobin · 2021-10-16T20:11:03Z

Proposal implementation of #20234 (closes #20234)

Proposal

namespace System.IO
{
    public static partial class File
    {
        public static DateTime GetCreationTime(SafeFileHandle fileHandle);
        public static DateTime GetCreationTimeUtc(SafeFileHandle fileHandle);
        public static DateTime GetLastAccessTime(SafeFileHandle fileHandle);
        public static DateTime GetLastAccessTimeUtc(SafeFileHandle fileHandle);
        public static DateTime GetLastWriteTime(SafeFileHandle fileHandle);
        public static DateTime GetLastWriteTimeUtc(SafeFileHandle fileHandle);

        public static void SetCreationTime(SafeFileHandle fileHandle, DateTime creationTime);
        public static void SetCreationTimeUtc(SafeFileHandle fileHandle, DateTime creatinTimeUtc);
        public static void SetLastAccessTime(SafeFileHandle fileHandle, DateTime lastAccessTime);
        public static void SetLastAccessTimeUtc(SafeFileHandle fileHandle, DateTime lastAccessTimeUtc);
        public static void SetLastWriteTime(SafeFileHandle fileHandle, DateTime lastWriteTime);
        public static void SetLastWriteTimeUtc(SafeFileHandle fileHandle, DateTime lastWriteTimeUtc);

        public static FileAttributes GetAttributes(SafeFileHandle fileHandle);
        public static void SetAttributes(SafeFileHandle fileHandle, FileAttributes fileAttributes);
    }
}

Current state of implementation

/cc @Liryna

ghost · 2021-10-16T20:11:23Z

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Proposal implementation of #20234

⚠️ This is a draft

/cc @Liryna

Author:	deeprobin
Assignees:	-
Labels:	`area-System.IO`, `community-contribution`
Milestone:	-

src/libraries/System.Private.CoreLib/src/System/IO/FileSystem.Unix.cs

src/libraries/Common/src/System/IO/FileSystem.Attributes.Windows.cs

deeprobin · 2021-10-22T20:18:43Z

@danmoseley Do the files added under Common/src/Interop/Windows/Kernel32/ (see CI failures) have to be registered somewhere so that they can be resolved?

danmoseley · 2021-10-22T21:04:24Z

@deeprobin if you look at the build log you should see the project file on the end of the error:

2021-10-22T19:42:24.8792107Z D:\a\_work\2\s\src\libraries\Common\src\Interop\Windows\Kernel32\Interop.WIN32_FILE_ATTRIBUTE_DATA.cs(27,44): error CS0246: The type or namespace name 'BY_HANDLE_FILE_INFORMATION' could not be found (are you missing a using directive or an assembly reference?) [D:\a\_work\2\s\src\libraries\System.IO.FileSystem.AccessControl\src\System.IO.FileSystem.AccessControl.csproj]

You've introduced use of WIN32_FILE_ATTRIBUTE_DATA into a file in this project: the project file needs updating to include its source file.

danmoseley · 2021-10-22T22:40:26Z

@deeprobin are you able to build the libraries locally successfully? An incremental build under src\libraries should be less than a minute, and ought to have thrown up these errors locally, which would be quicker for you than waiting an hour or whatever for the PR validation system.

src/libraries/System.IO.FileSystem.AccessControl/src/System.IO.FileSystem.AccessControl.csproj

src/libraries/System.IO.FileSystem/tests/File/GetSetAttributes.cs

src/libraries/System.Private.CoreLib/src/System/IO/FileSystem.Unix.cs

danmoseley · 2021-10-22T23:24:30Z

Generally folks don't push changes one at a time, because it restarts PR validation, which is extensive -- 50+ configurations -- and that uses machine capacity. What I suggest is that you wait to push until you are satisfied with your changes and have done basic build and tests locally, then push everything (squashed or not as you prefer). Another option is that I mark this PR as draft, so that pushes don't kick off more validation (I think). What are your thoughts

deeprobin · 2021-10-23T15:14:26Z

Generally folks don't push changes one at a time, because it restarts PR validation, which is extensive -- 50+ configurations -- and that uses machine capacity. What I suggest is that you wait to push until you are satisfied with your changes and have done basic build and tests locally, then push everything (squashed or not as you prefer). Another option is that I mark this PR as draft, so that pushes don't kick off more validation (I think). What are your thoughts

Unfortunately, VS support doesn't currently work for me with .NET 7, so I've always validated that via CI.

src/libraries/System.Private.CoreLib/src/System/IO/FileSystem.Unix.cs

danmoseley · 2021-10-24T06:07:36Z

VS support doesn't currently work for me with .NET 7

You can build and run tests outside of VS. this is what I do. There is all the info you need in the workflow docs in this repo.

src/libraries/Common/src/Interop/Windows/Kernel32/Interop.BY_HANDLE_FILE_INFORMATION.cs

src/libraries/System.IO.FileSystem/tests/File/GetSetAttributes.cs

danmoseley · 2021-11-03T21:20:14Z

@deeprobin it looks like there's unix specific build errors. You don't need to be on a Unix box to reproduce those. Something like this at the root of the repo:
build clr.corelib -rc release -lc debug -os linux
or to build all the libraries
build clr.corelib+libs -rc release -lc debug -os linux

There should be a way to do it with dotnet build, but I have to check how.

deeprobin · 2021-11-03T21:41:18Z

@danmoseley Thank you. I'll fixed it (the unix-build is now passing locally)

src/libraries/Common/src/Interop/Windows/Kernel32/Interop.GetFileInformationByHandle.cs

src/libraries/System.IO.FileSystem.AccessControl/src/System.IO.FileSystem.AccessControl.csproj

src/libraries/Common/src/System/IO/FileSystem.Attributes.Windows.cs

src/libraries/System.Private.CoreLib/src/System/IO/FileSystem.Windows.cs

src/libraries/System.Private.CoreLib/src/System/IO/FileSystem.Unix.cs

danmoseley · 2021-12-12T22:34:58Z

It looks like you need to rebase on main as I made a concurrent change. It should be easy.

danmoseley · 2022-07-05T19:41:35Z

Can you please open a new issue for your failure:


Process terminated. Assertion failed.
ClientCertificates. Expected enumerable cloned value.
   at System.Net.Security.SslClientAuthenticationOptionsExtensions.ShallowClone(SslClientAuthenticationOptions options) in /_/src/libraries/Common/src/System/Net/Security/SslClientAuthenticationOptionsExtensions.cs:line 41
   at System.Net.Http.HttpConnectionSettings.CloneAndNormalize() in /_/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionSettings.cs:line 85
   at System.Net.Http.SocketsHttpHandler.SetupHandlerChain() in /_/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/SocketsHttpHandler.cs:line 486
   at System.Net.Http.SocketsHttpHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken) in /_/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/SocketsHttpHandler.cs:line 576

danmoseley · 2022-07-05T19:41:55Z

Cc @wfurt

deeprobin · 2022-07-06T20:15:15Z

@jozkee @danmoseley
I think this PR is ready-for-merge or do you find any possible improvements?

deeprobin · 2022-07-11T04:36:14Z

@jozkee Can you give another review (or approve)?

src/libraries/System.Private.CoreLib/src/System/IO/File.cs

src/libraries/System.Private.CoreLib/src/System/IO/FileStatus.SetTimes.OSX.cs

src/libraries/System.Private.CoreLib/src/System/IO/FileStatus.Unix.cs

@stephentoub

See comment by @stephentoub

Co-Authored-By: David Cantú <[email protected]>

Adapted from MSDN

src/libraries/System.Private.CoreLib/src/System/IO/File.cs

jozkee · 2022-07-12T16:05:31Z

@deeprobin if you are not planning on addressing the documentation feedback, could you please file an issue for it?

deeprobin · 2022-07-12T16:24:00Z

@deeprobin if you are not planning on addressing the documentation feedback, could you please file an issue for it?

I'll address it. Give me one hour ;)

Co-Authored-By: David Cantú <[email protected]>

deeprobin · 2022-07-12T16:50:34Z

@jozkee Doc changes applied

src/libraries/System.Private.CoreLib/src/System/IO/File.cs

jozkee · 2022-07-12T21:32:12Z

CI error is #66625

jozkee · 2022-07-12T21:33:07Z

Thanks, @deeprobin.

ghost added the community-contribution Indicates that the PR has been added by a community member label Oct 16, 2021

dotnet-issue-labeler bot added the area-System.IO label Oct 16, 2021

deeprobin commented Oct 16, 2021

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/IO/FileSystem.Unix.cs Outdated Show resolved Hide resolved

deeprobin commented Oct 16, 2021

View reviewed changes

src/libraries/Common/src/System/IO/FileSystem.Attributes.Windows.cs Outdated Show resolved Hide resolved

runfoapp bot mentioned this pull request Oct 18, 2021

Error in CI Mono llvmfullaot Pri0 Runtime Tests Run Linux arm64 release #60234

Closed

danmoseley reviewed Oct 22, 2021

View reviewed changes

src/libraries/System.IO.FileSystem.AccessControl/src/System.IO.FileSystem.AccessControl.csproj Outdated Show resolved Hide resolved

danmoseley reviewed Oct 22, 2021

View reviewed changes

src/libraries/System.IO.FileSystem/tests/File/GetSetAttributes.cs Outdated Show resolved Hide resolved

danmoseley reviewed Oct 22, 2021

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/IO/FileSystem.Unix.cs Outdated Show resolved Hide resolved

deeprobin commented Oct 23, 2021

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/IO/FileSystem.Unix.cs Show resolved Hide resolved

deeprobin commented Oct 25, 2021

View reviewed changes

src/libraries/Common/src/Interop/Windows/Kernel32/Interop.BY_HANDLE_FILE_INFORMATION.cs Outdated Show resolved Hide resolved

danmoseley reviewed Oct 25, 2021

View reviewed changes

src/libraries/System.IO.FileSystem/tests/File/GetSetAttributes.cs Outdated Show resolved Hide resolved

deeprobin mentioned this pull request Nov 2, 2021

[tracking]: Remove SafeFileHandle for Unix #61112

Closed

deeprobin commented Nov 4, 2021

View reviewed changes

src/libraries/Common/src/Interop/Windows/Kernel32/Interop.GetFileInformationByHandle.cs Outdated Show resolved Hide resolved

jeffhandley assigned jozkee Nov 15, 2021

jozkee reviewed Nov 16, 2021

View reviewed changes

jozkee added the needs-author-action An issue or pull request that requires more info or actions from the author. label Dec 4, 2021

ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Dec 11, 2021

huoyaoyuan mentioned this pull request Dec 14, 2021

Refactor FileStatus.Unix. #62721

Merged

deeprobin added 2 commits December 16, 2021 20:07

Implement proposal

80246ea

Undo auto-reformat

eb56003

deeprobin mentioned this pull request Jul 6, 2022

Test failure: System.Net.Security.SslClientAuthenticationOptionsExtensions #71697

Closed

deeprobin requested a review from jozkee July 6, 2022 20:14

jozkee reviewed Jul 11, 2022

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/IO/File.cs Show resolved Hide resolved

deeprobin added 2 commits July 11, 2022 20:29

Merge branch 'main' into issue-20234

f0697b5

Add null-validation

231c838

jozkee reviewed Jul 11, 2022

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/IO/FileStatus.SetTimes.OSX.cs Show resolved Hide resolved

src/libraries/System.Private.CoreLib/src/System/IO/FileStatus.Unix.cs Show resolved Hide resolved

deeprobin and others added 4 commits July 11, 2022 22:37

Move population into private helper method

c63501b

See comment by @stephentoub

Fix null-handling

f865a87

Add more debug assertions

880011b

Co-Authored-By: David Cantú <[email protected]>

Add code documentation

312b199

Adapted from MSDN

deeprobin requested a review from jozkee July 11, 2022 21:09

jozkee reviewed Jul 11, 2022

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/IO/File.cs Outdated Show resolved Hide resolved

runfoapp bot mentioned this pull request Jul 12, 2022

System.Runtime.InteropServices.JavaScript.Tests.JSImportExportTest.JSImportObject #71990

Closed

jozkee approved these changes Jul 12, 2022

View reviewed changes

Address documentation feedback

0d405b4

Co-Authored-By: David Cantú <[email protected]>

jozkee reviewed Jul 12, 2022

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/IO/File.cs Outdated Show resolved Hide resolved

Update src/libraries/System.Private.CoreLib/src/System/IO/File.cs

7cfc7e1

jozkee merged commit 15cb373 into dotnet:main Jul 12, 2022

karelz mentioned this pull request Jul 21, 2022

[WinHttp] Manual_CertificateOnlySentWhenValid_Success fails with WINHTTP_CALLBACK_STATUS_REQUEST_ERROR in rolling CI #69238

Open

ghost locked as resolved and limited conversation to collaborators Aug 12, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[API Implementation]: SafeFileHandle overloads for SetCreationTime, SetLastAccessTime, SetLastWriteTime #60507

[API Implementation]: SafeFileHandle overloads for SetCreationTime, SetLastAccessTime, SetLastWriteTime #60507

deeprobin commented Oct 16, 2021 •

edited

Loading

ghost commented Oct 16, 2021

deeprobin commented Oct 22, 2021

danmoseley commented Oct 22, 2021

danmoseley commented Oct 22, 2021

danmoseley commented Oct 22, 2021

deeprobin commented Oct 23, 2021

danmoseley commented Oct 24, 2021

danmoseley commented Nov 3, 2021

deeprobin commented Nov 3, 2021

danmoseley commented Dec 12, 2021

danmoseley commented Jul 5, 2022

danmoseley commented Jul 5, 2022

deeprobin commented Jul 6, 2022

deeprobin commented Jul 11, 2022

jozkee commented Jul 12, 2022

deeprobin commented Jul 12, 2022

deeprobin commented Jul 12, 2022

jozkee commented Jul 12, 2022

jozkee commented Jul 12, 2022

[API Implementation]: SafeFileHandle overloads for SetCreationTime, SetLastAccessTime, SetLastWriteTime #60507

[API Implementation]: SafeFileHandle overloads for SetCreationTime, SetLastAccessTime, SetLastWriteTime #60507

Conversation

deeprobin commented Oct 16, 2021 • edited Loading

Proposal

Current state of implementation

ghost commented Oct 16, 2021

deeprobin commented Oct 22, 2021

danmoseley commented Oct 22, 2021

danmoseley commented Oct 22, 2021

danmoseley commented Oct 22, 2021

deeprobin commented Oct 23, 2021

danmoseley commented Oct 24, 2021

danmoseley commented Nov 3, 2021

deeprobin commented Nov 3, 2021

danmoseley commented Dec 12, 2021

danmoseley commented Jul 5, 2022

danmoseley commented Jul 5, 2022

deeprobin commented Jul 6, 2022

deeprobin commented Jul 11, 2022

jozkee commented Jul 12, 2022

deeprobin commented Jul 12, 2022

deeprobin commented Jul 12, 2022

jozkee commented Jul 12, 2022

jozkee commented Jul 12, 2022

deeprobin commented Oct 16, 2021 •

edited

Loading